Drop the vendored rsmpeg/rusty_ffmpeg patches (libavdevice, bindgen 0.72) #458

Open
opened 2026-11-13 13:09:50 +00:00 by charles · 0 comments
Owner

Text chat 64 (#404) vendors rsmpeg 0.18.0 and rusty_ffmpeg 0.16.7 under third_party/ with two changes (see their PATCHES.md):

  1. No libavdevice. The bundled FFmpeg is configured with --disable-avdevice (plan Task 63), but the published rusty_ffmpeg links and binds all seven FFmpeg libraries unconditionally and rsmpeg has an avdevice module, so neither builds against our FFmpeg.
  2. bindgen 0.72. rusty_ffmpeg 0.16.7 asks for bindgen 0.71, which with libclang >= 22 generates every typedef-named struct (AVFormatContext, ...) as an opaque one-byte type, so rsmpeg does not compile on current distributions (seen on the desktop with clang 23). 0.72.1 is already in the graph for pipewire.

Ways to drop the vendoring later:

  • build FFmpeg with --enable-avdevice (no devices compiled in, a tiny extra library) in a revision r2 of tools/ffmpeg/ffmpeg.lock, plus LINUX_BUNDLED/WINDOWS_BUNDLED; or
  • upstream an optional-libavdevice change to rusty_ffmpeg/rsmpeg and wait for a release on bindgen >= 0.72.

Not urgent: the patch is two small diffs, covered by fluxer-media-playback's build and tests.

Text chat 64 (#404) vendors `rsmpeg` 0.18.0 and `rusty_ffmpeg` 0.16.7 under `third_party/` with two changes (see their `PATCHES.md`): 1. **No libavdevice.** The bundled FFmpeg is configured with `--disable-avdevice` (plan Task 63), but the published `rusty_ffmpeg` links and binds all seven FFmpeg libraries unconditionally and `rsmpeg` has an `avdevice` module, so neither builds against our FFmpeg. 2. **bindgen 0.72.** `rusty_ffmpeg` 0.16.7 asks for bindgen 0.71, which with libclang >= 22 generates every typedef-named struct (`AVFormatContext`, ...) as an opaque one-byte type, so `rsmpeg` does not compile on current distributions (seen on the desktop with clang 23). 0.72.1 is already in the graph for `pipewire`. Ways to drop the vendoring later: - build FFmpeg with `--enable-avdevice` (no devices compiled in, a tiny extra library) in a revision `r2` of `tools/ffmpeg/ffmpeg.lock`, plus `LINUX_BUNDLED`/`WINDOWS_BUNDLED`; or - upstream an optional-libavdevice change to rusty_ffmpeg/rsmpeg and wait for a release on bindgen >= 0.72. Not urgent: the patch is two small diffs, covered by `fluxer-media-playback`'s build and tests.
charles added this to the Text chat milestone 2026-11-13 13:09:50 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
charles/fluxer-native#458
No description provided.