Text chat 62: Rename the client to Flaxative, with a one-time migration of its folders and keyring entry (#402) #424
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "textchat-62-rename-flaxative"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Renames the client from Fluxer Native to Flaxative, with a one-time move of its folders and keyring entry (plan Task 62). Commits in the plan's order:
feat(platform):APP_NAME = "flaxative",LEGACY_APP_NAME = "fluxer-native",APP_DISPLAY_NAME = "Flaxative"(moved to the crate root, re-exported fromnotify),APP_ID = "flaxative",WINDOWS_APP_USER_MODEL_ID = "Forked.Flaxative".paths::migrate_legacy(&legacy, ¤t) -> Migration { moved, kept_both, failed }cuts each directory back to the folder that differs (so~/.local/state/fluxer-nativemoves as a whole, and folders that share a root, as on Windows, move once). It renames, or copies when rename fails (links copied as links, never followed) and removes the old tree only after a complete copy. A partial copy is removed again so the next start retries.Secrets::load_tokenreadsflaxative/host, falls back tofluxer-native/host, writes it underflaxativeand deletes the old entry only after that write succeeded.clear_token(logout) deletes both.feat(capture,audio): the capture stream'sapplication.nameisFlaxative, the sink isflaxative-stream-audio-<pid>-<n>/ "Flaxative Stream Audio".routing::is_own_sinkandfluxer-audio's device list recognise both prefixes and both descriptions. Self identity keeps every old name and adds the Flaxative names and prefixes.feat(api,ui):fluxer_api::USER_AGENT = "Flaxative/<version>", window title "Flaxative", and on Linuxplatform_specific.application_id = "flaxative".feat(app):[[bin]] name = "flaxative"(cargo run -p fluxerstill works), clap name/about,flaxative.<date>.log,--debug-infofirst lineflaxative <version> (git <sha>), devserver dirflaxative-devserver-<pid>. The migration runs before logging and the settings, not with--devserver, and is logged once (paths only). On Windows,SetCurrentProcessExplicitAppUserModelIDruns before the window opens.build:Flaxative-<version>-linux-x86_64.AppImage/Flaxative-<version>-win-x64.exe,Flaxative.AppDir,usr/bin/flaxative,flaxative.desktop(Exec=flaxative %U,Icon=flaxative,StartupWMClass=flaxative),flaxative.svg.AppRunmessages are renamed. The release and nightly names and bodies are renamed. Crate descriptions, READMEs and CLAUDE.md's heading are updated.What Charles sees on first start: still logged in, with his settings, cache and logs kept. The folders are moved before anything reads them, and the keyring token moves the first time it is read. The old nightly links (
…/download/nightly/Fluxer-Native-*.AppImage/.exe) stop working: the nightly job deletes and recreates thenightlyrelease, so the first renamed run removes the old-named assets, and the new release body says the client was renamed.Tests
paths_use_the_flaxative_folders,legacy_folders_are_moved_once,folders_sharing_a_root_are_moved_once,migration_is_idempotent,migration_keeps_both_when_the_new_folder_exists,migration_copies_when_rename_fails(rename injected to fail withCrossesDevices),partial_copy_never_deletes_the_legacy_tree,keyring_token_moves_to_the_new_service,keyring_prefers_the_new_entry,keyring_keeps_the_legacy_entry_when_the_write_fails,logout_deletes_both_entries,app_id_is_the_windows_app_id;self_identity_matches_new_and_old_names,capture_stream_announces_flaxative,own_sink_matches_both_prefixes;own_nodes_hidden_under_both_names;user_agent_names_flaxative;window_title_is_flaxative,linux_app_id_is_flaxative;debug_info_first_line_names_flaxative,log_files_are_named_flaxative;package_file_names_are_flaxative,appimage_has_flaxative_desktop_icon_and_binary(also runs--helpand--debug-infoof the packaged binary and checks for no old names),desktop_entry_icon_exec_and_wm_class_match_app_id,no_old_product_name_in_shipped_files. Each test was seen failing (compile error or assertion) before its implementation.FLUXER_SCREENSHOT_TESTS=1 cargo xtask cipassed locally (Linux, before the final merge of origin/textchat; that merge only touched the two workflows, and the workflow name scan was re-run after it).HOME/XDG_*holding copies of the real~/.config/fluxer-native,~/.cache/fluxer-native(82 MB) and~/.local/state/fluxer-native. It logged three "moved a folder of the client's old name" lines, and settings, cache and logs were in theflaxativefolders. D-Bus was pointed nowhere, so the real keyring was not touched; the keyring move is covered by the unit tests only. No live login.Deviations
Target::package_name(notfile_name), andSecrets::new(host).load_token()/clear_token()(notSecrets::load/delete).paths.rs/secrets.rs, nottests/, because they need the failure injection and the#[cfg(test)]mock keyring.WM_CLASSinstance and class both toflaxative, not classFlaxative. That is whatStartupWMClassmatches.application.name. It is derived from the binary (flaxative), andfluxer-capture/fluxer-audioREADMEs say so.packaging/windows/fluxer-native.ico→flaxative.icomoved with commit 4 (not 5), sobuild.rskeeps finding the icon at every commit..forgejo/workflows/ci.yamlhas no binary paths, so it is unchanged. The runners' cache dirs (R:\fcargo\fluxer-native) keep their names, to avoid a cold rebuild and a duplicated cache.toastcode names no AppUserModelID, so it is unchanged.browser: "Fluxer Native"influxer-proto, which the server shows in the sessions list.fluxer.<date>.logfiles moved with the folder are not pruned by theflaxative.*rotation.Closes #402
🤖 Generated with Claude Code
The capture stream announces application.name "Flaxative"; the private sink is flaxative-stream-audio-<pid>-<n> ("Flaxative Stream Audio"). Self identity and the device lists also exclude every old name and the legacy fluxer-native-stream-audio- prefix (routing::is_own_sink). Refs #402 Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>Review of Text chat 62 (rename to Flaxative), independent reviewer.
Checked: the plan's named tests are all present and assert the spec values (platform paths/migration/keyring, PipeWire self-identity and own-sink prefixes, audio node hiding, user agent, window title and app id, debug-info/log names, xtask package names, AppImage contents, desktop entry, old-name scan). Interfaces exist as written, apart from deviations where the merged code wins (
Target::package_name,Secrets::load_token/clear_token). No changes to fluxer-core, fluxer-emoji or proto; the only fluxer-ui changes arepub const TITLE/APP_IDandwindow_settingswith the Linuxapplication_id(no I/O). The token is never logged; the migration logs paths only.Paths::under) are correct; covered byfolders_sharing_a_root_are_moved_once.setsucceeds, and a failed write still returns the token. OK.--devserverand--debug-info. OK.browseris still "Fluxer Native" (fluxer-proto, outside the Files list). It is a follow-up candidate, not part of this task.Win32_UI_Shell) has not been compiled anywhere yet. The Windows runner is its first build.Local
cargo xtask ci: started in the review worktree but did NOT finish before the reviewer had to report. Result: not recorded.Verdict: no blocking code findings. Approval withheld until ci is confirmed green (local or both runners).
Review round 1, minor findings:
Win32_UI_Shellis in the workspacewindowsfeatures. The first Windows runner build of this branch still has to confirm that it compiles.cargo xtask ciresult not recorded: I started a new localFLUXER_SCREENSHOT_TESTS=1 cargo xtask cirun on4326425. It had not finished when this agent had to return, so the CI result is still not recorded.No commits were added in this round.
Independent review: Text chat 62 (rename to Flaxative), head
4326425I reviewed this cold:
git diff 67da1c7..origin/textchat-62-rename-flaxative, Task 62's own changes only.Checked and correct
user_agent_names_flaxative,window_title_is_flaxative,linux_app_id_is_flaxative, the debug-info and log-file tests, and the xtask package tests.partial_copy_never_deletes_the_legacy_treeinjects a failing copy and checks that the legacy tree stays whole, that no partial copy is left, and that a retry succeeds.migration_copies_when_rename_failsusesCrossesDevicesand checks that symlinks are copied as links.APP_NAME,LEGACY_APP_NAME,APP_DISPLAY_NAME(re-exported fromnotify),APP_ID,WINDOWS_APP_USER_MODEL_ID,paths::migrate_legacyandMigration { moved, kept_both, failed }all match the plan. So doSERVICE/LEGACY_SERVICE,CLIENT_APPLICATION_NAME, the new display names and prefixes,OWN_SINK_PREFIX/LEGACY_OWN_SINK_PREFIX,USER_AGENT, the[[bin]] flaxative, the clap name, the package file names, the desktop file (StartupWMClass=flaxative) and the nightly names. The plan calls itSecrets::load; the merged code hasload_token, and the merged code is the source of truth here.main.rs: it runs after--debug-inforeturns and before logging, the settings and the cache open; it is skipped with--devserver; the outcome is logged as paths only. The keyring entry moves only after the new write succeeds, logout clears both entries, and the token is never logged.windowscrate is already in the graph, and only theWin32_UI_Shellfeature is added).FLUXER_SCREENSHOT_TESTS=1 cargo xtask ciin a clean review worktree: all steps passed (screenshot tests included).Findings
crates/fluxer-proto/src/gateway/identify.rsstill sendsBROWSER = "Fluxer Native". That breaks the rename rule but is outside Task 62's file list, and #425 tracks it. Not blocking.xtask/README.md:52still saysrun dist/Fluxer-Native-*.AppImage. Stale doc text;no_old_product_name_in_shipped_filesdoes not scan READMEs.set_app_user_model_id(Windows) has not been compiled locally. Only the Windows runner can confirm it builds; the integrator should check that runner before merging.migrate_with, when the copy succeeds but the old tree cannot be removed, the folder is listed in bothmovedandfailed, and the log says "trying again at the next start". On the next start both folders exist, so it lands inkept_bothand nothing is retried. The data is safe; only the log message is misleading.Verdict: approve. No blocking findings, and local CI is green. The Windows runner still has to confirm finding 3.