Synced preferences: one writer of the snapshot in fluxer-core (Text chat 14 and 19) #370

Open
opened 2026-11-12 23:14:04 +00:00 by charles · 0 comments
Owner

Found in the review of Text chat 19 (PR #350, issue #269).

Two reducers in fluxer-core PATCH whole synced_preferences snapshots: chat::settings::SyncedDisplay::write (Text chat 19, the sanitize_urls field 82) builds on app.chat.display.synced_preferences, and the expressions prefs writer (Text chat 14) keeps its own prefs.base. If one write is in flight while the other is sent, the second is built on a snapshot without the first: picker frecency or favourites written by 14 can be replaced by an older copy, or a sanitize_urls toggle undone. The window is one round trip.

To do: give the snapshot one owner in fluxer-core (for example route the field 82 change through the expressions prefs writer, or share its base and queue writes), and cover two overlapping writes with a test. Related: #308 (base hash and 409 conflict handling).

Seen on commit 1630a19 (branch textchat-19-core-dms-settings).

Found in the review of Text chat 19 (PR #350, issue #269). Two reducers in `fluxer-core` PATCH whole `synced_preferences` snapshots: `chat::settings::SyncedDisplay::write` (Text chat 19, the `sanitize_urls` field 82) builds on `app.chat.display.synced_preferences`, and the expressions prefs writer (Text chat 14) keeps its own `prefs.base`. If one write is in flight while the other is sent, the second is built on a snapshot without the first: picker frecency or favourites written by 14 can be replaced by an older copy, or a `sanitize_urls` toggle undone. The window is one round trip. To do: give the snapshot one owner in `fluxer-core` (for example route the field 82 change through the expressions prefs writer, or share its base and queue writes), and cover two overlapping writes with a test. Related: #308 (base hash and 409 conflict handling). Seen on commit 1630a19 (branch textchat-19-core-dms-settings).
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
charles/fluxer-native#370
No description provided.