livekit patch: receive stereo in dual peer connection mode #359

Open
opened 2026-11-12 21:25:31 +00:00 by charles · 0 comments
Owner

Follow-up from the review of #358 (Text chat 54, #354).

The stereo patch of third_party/livekit (see third_party/livekit/PATCHES.md, "Not covered") does not munge the subscriber's own answer in dual peer connection mode, which is used when a server declines single PC. The JS client sets stereo=1 on the mids that its offer marks as stereo. In single PC mode, the SDK default and the mode used against livekit-server 1.12.0 (the instance's version), stereo is already received through upstream's munge_stereo_for_audio.

To do: munge the subscriber answer's Opus fmtp for the mids the remote offer marks stereo=1. Add a unit test and, if possible, an interop test with single PC turned off.

Seen on commit 0167c95.

Follow-up from the review of #358 (Text chat 54, #354). The stereo patch of `third_party/livekit` (see `third_party/livekit/PATCHES.md`, "Not covered") does not munge the subscriber's own answer in dual peer connection mode, which is used when a server declines single PC. The JS client sets `stereo=1` on the mids that its offer marks as stereo. In single PC mode, the SDK default and the mode used against livekit-server 1.12.0 (the instance's version), stereo is already received through upstream's `munge_stereo_for_audio`. To do: munge the subscriber answer's Opus fmtp for the mids the remote offer marks `stereo=1`. Add a unit test and, if possible, an interop test with single PC turned off. Seen on commit 0167c95.
charles added this to the Text chat milestone 2026-11-12 21:25:31 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
charles/fluxer-native#359
No description provided.