Composer follow-ups: Markdown links in emoticon conversion, mention ranking, draft load order #347

Open
opened 2026-11-12 18:58:21 +00:00 by charles · 0 comments
Owner

Deferred from the review of PR #309 (Text chat 11, core composer), seen on commit 1ea0a32.

  1. crates/fluxer-core/src/chat/content.rs protected_len protects only bare http(s):// URLs, not Markdown links [text](url) as the original's findMarkdownLinkEnd does. With emoticons on, [see :) here](https://x) converts the :); the original leaves it. The module doc and the crate README say "links" stay untouched, which overstates it.
  2. crates/fluxer-core/src/chat/autocomplete.rs mentions() puts recent authors first even for a non-empty query; spec §3.2 says recent speakers come first only when the query is empty (ranking only).
  3. crates/fluxer-core/src/app.rs loads stored drafts only on the logged-out to logged-in transition and only if Persisted::Loaded has already arrived. If login ever finished before the settings file loaded, the first draft save would overwrite stored drafts. Not reachable today (startup loads first); loading drafts on Loaded while logged in would make it robust.

Also noted for parity (no action required): reply message_reference is sent with guild_id: None; limits_of resolves guild features from ui.selected_channel rather than the draft's channel (carried over from Text chat 10).

Deferred from the review of PR #309 (Text chat 11, core composer), seen on commit 1ea0a32. 1. `crates/fluxer-core/src/chat/content.rs` `protected_len` protects only bare `http(s)://` URLs, not Markdown links `[text](url)` as the original's `findMarkdownLinkEnd` does. With emoticons on, `[see :) here](https://x)` converts the `:)`; the original leaves it. The module doc and the crate README say "links" stay untouched, which overstates it. 2. `crates/fluxer-core/src/chat/autocomplete.rs` `mentions()` puts recent authors first even for a non-empty query; spec §3.2 says recent speakers come first only when the query is empty (ranking only). 3. `crates/fluxer-core/src/app.rs` loads stored drafts only on the logged-out to logged-in transition and only if `Persisted::Loaded` has already arrived. If login ever finished before the settings file loaded, the first draft save would overwrite stored drafts. Not reachable today (startup loads first); loading drafts on `Loaded` while logged in would make it robust. Also noted for parity (no action required): reply `message_reference` is sent with `guild_id: None`; `limits_of` resolves guild features from `ui.selected_channel` rather than the draft's channel (carried over from Text chat 10).
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
charles/fluxer-native#347
No description provided.