proto: model attachment duration/waveform and partial-forward reference fields #298

Open
opened 2026-11-12 13:12:22 +00:00 by charles · 0 comments
Owner

Found in review of Text chat 2 (#252, branch textchat-2-proto-chat-requests-events at 72b970a). Not modelled in fluxer-proto yet:

  • AttachmentPayload has no duration / waveform. The original sends them for voice messages (fork:fluxer_app/src/features/messaging/utils/MessageAttachmentUtils.ts:35-36).
  • MessageReferenceRequest has no attachment_ids / embed_indices (partial forwards).

Neither is needed by the tasks that consume these types today. AttachmentPayload and MessageReferenceRequest are built with struct literals, so adding fields touches every constructor. Add them, with skip_serializing_if and a spec-contract check, when voice messages or partial forwards are planned.

Found in review of Text chat 2 (#252, branch `textchat-2-proto-chat-requests-events` at 72b970a). Not modelled in `fluxer-proto` yet: - `AttachmentPayload` has no `duration` / `waveform`. The original sends them for voice messages (`fork:fluxer_app/src/features/messaging/utils/MessageAttachmentUtils.ts:35-36`). - `MessageReferenceRequest` has no `attachment_ids` / `embed_indices` (partial forwards). Neither is needed by the tasks that consume these types today. `AttachmentPayload` and `MessageReferenceRequest` are built with struct literals, so adding fields touches every constructor. Add them, with `skip_serializing_if` and a spec-contract check, when voice messages or partial forwards are planned.
charles added this to the Text chat milestone 2026-11-12 13:12:22 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
charles/fluxer-native#298
No description provided.