UserPrivate.traits is not modelled; limit resolution sees no traits #185

Open
opened 2026-11-12 02:25:36 +00:00 by charles · 0 comments
Owner

fluxer_proto::limits::resolve takes the user's traits (premium, ...), which the fork reads from traits of the current user (LimitContext.build in fluxer_app/src/features/app/utils/LimitResolverAdapter.ts). UserPrivate does not model traits yet: it is listed in the ignored fields of user_me.json in crates/fluxer-proto/tests/models_roundtrip.rs ("sub-projects 6 and 7").

Until it is modelled, the screen-share entitlement (Screen share 11) resolves limits with no traits, i.e. as a free user: feature_higher_video_quality and max_screen_share_bitrate come from the unfiltered rules only. On an instance that grants higher quality through a premium trait rule, the native client would clamp to 720p30.

Fix: add traits: Vec<String> (absent = empty) to UserPrivate, drop it from the ignored fields, and have the core pass it to resolve. Seen while implementing Screen share 7 (#154), branch screenshare-7-proto-api-streams.

`fluxer_proto::limits::resolve` takes the user's traits (`premium`, ...), which the fork reads from `traits` of the current user (`LimitContext.build` in `fluxer_app/src/features/app/utils/LimitResolverAdapter.ts`). `UserPrivate` does not model `traits` yet: it is listed in the ignored fields of `user_me.json` in `crates/fluxer-proto/tests/models_roundtrip.rs` ("sub-projects 6 and 7"). Until it is modelled, the screen-share entitlement (Screen share 11) resolves limits with no traits, i.e. as a free user: `feature_higher_video_quality` and `max_screen_share_bitrate` come from the unfiltered rules only. On an instance that grants higher quality through a `premium` trait rule, the native client would clamp to 720p30. Fix: add `traits: Vec<String>` (absent = empty) to `UserPrivate`, drop it from the ignored fields, and have the core pass it to `resolve`. Seen while implementing Screen share 7 (#154), branch `screenshare-7-proto-api-streams`.
charles added this to the Screen share milestone 2026-11-12 02:25:36 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
charles/fluxer-native#185
No description provided.