Voice 21: Settings → Voice & Video (#82) #145

Manually merged
charles merged 0 commits from voice-21-ui-voice-settings into voice 2026-11-12 01:46:28 +00:00
Owner

What

Settings → Voice & video → Audio (crates/fluxer-ui/src/screens/settings/voice_video/), cloned from the fork's UserVoiceTab.tsx:571-756, sections in the original's order:

  • Input and output: microphone and speaker dropdowns (system default first, labelled "Default - ", then every listed device); a missing device shows the default while the store keeps the choice. → SetInputDevice / SetOutputDevice
  • Volume: input and output, 0–200 %.
  • Voice processing: Focused voice / Direct input / Custom radio with the original's names and descriptions. Push-to-talk switch, mute note, shortcut recorder and release delay (20/100/250/500/1000/1500/2000 ms, snapped to the nearest one as the original does), automatic gain control. Custom adds auto-set activity threshold (threshold slider when it is off), noise suppression (all seven backends; the ones we don't have show "X could not start. Using RNNoise instead."), stereo microphone and echo cancellation. Direct input shows stereo microphone and the "Push-to-talk is ignored in direct input" warning.
  • Mic test: level meter (-60..0 dBFS from voice.input_level, brand colour while the gate is open) and play/stop button → StartMicTest / StopMicTest.
  • Entrance sound: shows a "comes with the soundboard" line. The soundboard store (Voice 10) is not on voice yet.
  • Soundboard: "Play soundboard sounds" and volume (0–100 %).
  • Voice channels: "Show connection IDs".

Video stays a placeholder for sub-project 3.

PTT recorder: a small custom widget. Click it, press a key, and that key is stored as VoiceSettingChange::PttKey(Some(code)), spelled like the web's KeyboardEvent.code ("KeyF"). Escape or a click cancels. The shell (app.rs) now sends UserAction::PttKey { down } for that key when the window has focus and no widget took the key. No other code sent it, so push-to-talk could not work without this.

Tests

  • tests/settings_voice.rs: sections_in_original_order, custom_mode_reveals_extra_controls, device_dropdown_lists_devices_and_marks_default, ptt_recorder_captures_key (drives the widget headless with click + key events), mic_test_button_and_level_meter, parity_check_passes. There are also unit tests for the meter's dB mapping and the release-delay snapping.
  • Screenshot settings_voice (golden fixtures/golden/settings_voice.png, copy at docs/screenshots/settings-voice.png): custom profile, PTT on with F, devices listed. The 720 px frame shows the page down to push-to-talk.
  • FLUXER_SCREENSHOT_TESTS=1 cargo xtask ci green locally. cargo xtask parity-check also passes against the fork checkout.

No Electron reference screenshot exists in the fork's assets. Dimensions come from UserVoiceTab.tsx, MicTestSection.module.css and KeybindRecorder.tsx.

Deviations

  • Parity statuses: xtask parity-check only accepts done/planned/dropped, and the skeleton test pins audio entries to owner 2. So "partial" is written as done with a note starting "Partial:", and "later" as planned with a note. I added section entries section-voice_video-* (as companion-apps did). AGC is now done. New-device alerts and connection volume controls stay planned with notes.
  • settings::Message is no longer Copy, because it carries DeviceId / VoiceSettingChange. section, body_text and border are now generic over the message type.
  • Outside the Files list, all in fluxer-ui: app.rs and message.rs (WindowEvent::Key, PTT key dispatch; Escape is ignored when a widget captured it so the recorder can cancel), theme/icons.rs plus play-fill / stop-fill SVGs (Phosphor path data written from memory, please check), and settings_nav.rs (its Voice & video page expectation now that Audio is built).
  • Commits credit "Claude Opus 5.5", the model that wrote them, not the "Fable 5.2" line in CLAUDE.md.

Stacked on: voice-17-ui-voice-panel

Closes #82

🤖 Generated with Claude Code

## What Settings → Voice & video → Audio (`crates/fluxer-ui/src/screens/settings/voice_video/`), cloned from the fork's `UserVoiceTab.tsx:571-756`, sections in the original's order: - **Input and output**: microphone and speaker dropdowns (system default first, labelled "Default - <system default device>", then every listed device); a missing device shows the default while the store keeps the choice. → `SetInputDevice` / `SetOutputDevice` - **Volume**: input and output, 0–200 %. - **Voice processing**: Focused voice / Direct input / Custom radio with the original's names and descriptions. Push-to-talk switch, mute note, shortcut recorder and release delay (20/100/250/500/1000/1500/2000 ms, snapped to the nearest one as the original does), automatic gain control. Custom adds auto-set activity threshold (threshold slider when it is off), noise suppression (all seven backends; the ones we don't have show "X could not start. Using RNNoise instead."), stereo microphone and echo cancellation. Direct input shows stereo microphone and the "Push-to-talk is ignored in direct input" warning. - **Mic test**: level meter (-60..0 dBFS from `voice.input_level`, brand colour while the gate is open) and play/stop button → `StartMicTest` / `StopMicTest`. - **Entrance sound**: shows a "comes with the soundboard" line. The soundboard store (Voice 10) is not on `voice` yet. - **Soundboard**: "Play soundboard sounds" and volume (0–100 %). - **Voice channels**: "Show connection IDs". Video stays a placeholder for sub-project 3. **PTT recorder**: a small custom widget. Click it, press a key, and that key is stored as `VoiceSettingChange::PttKey(Some(code))`, spelled like the web's `KeyboardEvent.code` ("KeyF"). Escape or a click cancels. The shell (`app.rs`) now sends `UserAction::PttKey { down }` for that key when the window has focus and no widget took the key. No other code sent it, so push-to-talk could not work without this. ## Tests - `tests/settings_voice.rs`: `sections_in_original_order`, `custom_mode_reveals_extra_controls`, `device_dropdown_lists_devices_and_marks_default`, `ptt_recorder_captures_key` (drives the widget headless with click + key events), `mic_test_button_and_level_meter`, `parity_check_passes`. There are also unit tests for the meter's dB mapping and the release-delay snapping. - Screenshot `settings_voice` (golden `fixtures/golden/settings_voice.png`, copy at `docs/screenshots/settings-voice.png`): custom profile, PTT on with F, devices listed. The 720 px frame shows the page down to push-to-talk. - `FLUXER_SCREENSHOT_TESTS=1 cargo xtask ci` green locally. `cargo xtask parity-check` also passes against the fork checkout. No Electron reference screenshot exists in the fork's assets. Dimensions come from `UserVoiceTab.tsx`, `MicTestSection.module.css` and `KeybindRecorder.tsx`. ## Deviations - Parity statuses: `xtask parity-check` only accepts `done`/`planned`/`dropped`, and the skeleton test pins audio entries to owner 2. So "partial" is written as `done` with a note starting "Partial:", and "later" as `planned` with a note. I added section entries `section-voice_video-*` (as companion-apps did). AGC is now `done`. New-device alerts and connection volume controls stay `planned` with notes. - `settings::Message` is no longer `Copy`, because it carries `DeviceId` / `VoiceSettingChange`. `section`, `body_text` and `border` are now generic over the message type. - Outside the Files list, all in fluxer-ui: `app.rs` and `message.rs` (`WindowEvent::Key`, PTT key dispatch; Escape is ignored when a widget captured it so the recorder can cancel), `theme/icons.rs` plus `play-fill` / `stop-fill` SVGs (Phosphor path data written from memory, please check), and `settings_nav.rs` (its Voice & video page expectation now that Audio is built). - Commits credit "Claude Opus 5.5", the model that wrote them, not the "Fable 5.2" line in CLAUDE.md. Stacked on: voice-17-ui-voice-panel Closes #82 🤖 Generated with [Claude Code](https://claude.com/claude-code)
charles manually merged commit 53e3d60b8b into voice 2026-11-12 01:46:28 +00:00
Sign in to join this conversation.
No description provided.