Voice 14: the LiveKit SDK's own log records carry the access token #126

Closed
opened 2026-11-11 20:45:30 +00:00 by charles · 1 comment
Owner

From the review of PR #121 (Voice 13), minor finding on Review Focus 7 (no token may reach logs or --record output; tested in Voice 14).

The LiveKit SDK logs through the log crate, and its signalling records at debug level contain the access token (the join URL and the signal requests). Today nothing bridges log to tracing, so none of it reaches the log file. If Voice 14 (#75) adds a bridge (tracing-log or similar), the SDK's records need the same redaction as ours, or the livekit* and libwebrtc targets must be capped above debug.

Seen on commit 2a9d563. The server half of the finding is fixed there: cargo xtask ci no longer passes the dev server's debug log (which prints the dev-key tokens) on to the CI log.

To do in Voice 14: a test that a session connected with a known token, with SDK logging at its most verbose, leaves no trace of the token in the log file or the --record output.

From the review of PR #121 (Voice 13), minor finding on Review Focus 7 (no token may reach logs or `--record` output; tested in Voice 14). The LiveKit SDK logs through the `log` crate, and its signalling records at debug level contain the access token (the join URL and the signal requests). Today nothing bridges `log` to `tracing`, so none of it reaches the log file. If Voice 14 (#75) adds a bridge (`tracing-log` or similar), the SDK's records need the same redaction as ours, or the `livekit*` and `libwebrtc` targets must be capped above debug. Seen on commit 2a9d563. The server half of the finding is fixed there: `cargo xtask ci` no longer passes the dev server's debug log (which prints the dev-key tokens) on to the CI log. To do in Voice 14: a test that a session connected with a known token, with SDK logging at its most verbose, leaves no trace of the token in the log file or the `--record` output.
charles added this to the Voice milestone 2026-11-11 20:45:30 +00:00
Author
Owner

Done on textchat (c24495a): apps/fluxer/src/logging.rs:11,82-129: a log→tracing bridge with redact() of URL queries and tokens

Closed during the 2026-11-14 issue triage.

🤖 Generated with Claude Code

Done on `textchat` (c24495a): `apps/fluxer/src/logging.rs:11,82-129`: a `log`→`tracing` bridge with `redact()` of URL queries and tokens Closed during the 2026-11-14 issue triage. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
charles/fluxer-native#126
No description provided.