Marquees as jpg too, cabinets from the mirror only #71

Open
charles wants to merge 0 commits from fix/marquee-jpg into main
Owner

Three things.

  1. Marquees are asked for as png and jpg. R2-MIRROR.md says the set is 9242 png and 6099 jpg with 4467 basenames existing as both; asking only for png missed every jpg-only game and the 404 was indistinguishable from no art. Found 2 marquees previously reported absent, replaced 1.

  2. Cabinets come from the mirror or not at all. LaunchBox and EmuMovies only have photographs, and the layout composites into a 1300x1080 render with cut-outs rather than displaying a picture. Time Killers was a correct photo of a Time Killers cabinet and still wrong. Guard sits in the fetch loop so a new source cannot reintroduce it.

  3. R2-MIRROR.md corrected: not all mirror cabinets have cut-outs (68 of 166 do), and bezels no longer come from archive.org.

Three things. 1. Marquees are asked for as png and jpg. R2-MIRROR.md says the set is 9242 png and 6099 jpg with 4467 basenames existing as both; asking only for png missed every jpg-only game and the 404 was indistinguishable from no art. Found 2 marquees previously reported absent, replaced 1. 2. Cabinets come from the mirror or not at all. LaunchBox and EmuMovies only have photographs, and the layout composites into a 1300x1080 render with cut-outs rather than displaying a picture. Time Killers was a correct photo of a Time Killers cabinet and still wrong. Guard sits in the fetch loop so a new source cannot reintroduce it. 3. R2-MIRROR.md corrected: not all mirror cabinets have cut-outs (68 of 166 do), and bezels no longer come from archive.org.
R2-MIRROR.md says it plainly and I had not read it: the marquee set is 9,242
png and 6,099 jpg, and 4,467 basenames exist as both. A fetcher asking only for
<rom>.png misses every jpg-only game, and the 404 it gets back is
indistinguishable from "no art for this machine" -- which is exactly how they
were being counted.

On the cabinet, with 191 games installed: 2 marquees that had been reported as
absent, and 1 where the mirror's jpg differed from the png here.

Writing under the extension the mirror served means a jpg can arrive where a
png sits, so the loser is removed. Two files for one machine is not a saving,
it is Attract-Mode picking one by its own ordering rather than by ours.

.mp4 is not asked for: the animated marquees are on the other side of the
bucket's split, and a marquee slot takes a still image.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Nz3es8PajUzXmqJJiK6yRB
The cabinets are described as renders with transparent cut-outs for the
marquee. 68 of the 166 installed are; 98 are not, and 70 of those came from
this bucket. The distribution is cleanly bimodal -- ~84.5% transparent in the
layout's marquee rect, or under 40% -- so it is measurable rather than a
judgement call, and it matters: a cab with no cut-out already has its marquee
printed on it, and the layout's overlay lands on top of it.

Bezels no longer come from archive.org.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Nz3es8PajUzXmqJJiK6yRB
Time Killers was showing a photograph of a Time Killers cabinet: right game,
wrong artwork. 691x1395, angled, opaque. The layout does not display a cabinet
picture, it composites into one -- a 1300x1080 front-facing render with the
marquee and screen cut out -- and a photograph cannot be composited into.

LaunchBox's "Arcade - Cabinet" and EmuMovies' "Cabinets" are both photographs,
so both are dropped as cabinet sources. The guard sits in the fetch loop rather
than in each source's own kind mapping: four mappings that must each stay
correct is four chances to put photographs back, and an ARTWORK_SOURCES
template pointed somewhere new would have bypassed all of them anyway.

Marquees and wheels still come from LaunchBox. Only cabinets are affected,
because only cabinets have to be a particular shape to work at all.

On the cabinet: 176 installed, 171 already renders from the mirror, 5
photographs removed -- diehard, nitrobal, ssriders, svcpcb, timekill. Those
five now have no cabinet art, which is the intended outcome: the mirror holds
one object per game and has nothing for them.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Nz3es8PajUzXmqJJiK6yRB
This branch is already included in the target branch. There is nothing to merge.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin fix/marquee-jpg:fix/marquee-jpg
git switch fix/marquee-jpg

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch main
git merge --no-ff fix/marquee-jpg
git switch fix/marquee-jpg
git rebase main
git switch main
git merge --ff-only fix/marquee-jpg
git switch fix/marquee-jpg
git rebase main
git switch main
git merge --no-ff fix/marquee-jpg
git switch main
git merge --squash fix/marquee-jpg
git switch main
git merge --ff-only fix/marquee-jpg
git switch main
git merge fix/marquee-jpg
git push origin main
Sign in to join this conversation.
No reviewers
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
charles/arcade-nix!71
No description provided.